[coreboot-gerrit] Change in coreboot[master]: soc/amd/common/block/acpi: Extract event logging helpers

[Furquan Shaikh (Code Review)]

Attention is currently required from: Jason Glenesk, Martin Roth, Karthik Ramasubramanian, Felix Held.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56360 )

Change subject: soc/amd/common/block/acpi: Extract event logging helpers
......................................................................

Patch Set 3:

(3 comments)

File src/soc/amd/common/block/acpi/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/56360/comment/56de6e08_7cf6636c 
PS3, Line 16: romstage-y += elog.c
Is this required?

File src/soc/amd/common/block/acpi/elog.c:

https://review.coreboot.org/c/coreboot/+/56360/comment/06b75c87_fe61137e 
PS3, Line 37: if (!CONFIG(ELOG))
            : 		return;
nit: all the above functions already are guarded with !CONFIG(ELOG). Do we need the check here as well? Do these functions not get optimized out already without the check here?

File src/soc/amd/common/block/include/amdblocks/elog.h:

https://review.coreboot.org/c/coreboot/+/56360/comment/55792eef_6fa808cf 
PS3, Line 8: void acpi_log_events(const struct chipset_power_state *ps);
Can this be added to amdblocks/acpi.h itself?