Attention is currently required from: Jason Glenesk, Martin Roth, Karthik Ramasubramanian, Felix Held.

View Change

3 comments:

• File src/soc/amd/common/block/acpi/Makefile.inc:

  • Patch Set #3, Line 16: romstage-y += elog.c

    Is this required?

• File src/soc/amd/common/block/acpi/elog.c:

  • Patch Set #3, Line 37:

    if (!CONFIG(ELOG))
    		return;
    

    nit: all the above functions already are guarded with !CONFIG(ELOG). Do we need the check here as well? Do these functions not get optimized out already without the check here?

• File src/soc/amd/common/block/include/amdblocks/elog.h:

  • Patch Set #3, Line 8: void acpi_log_events(const struct chipset_power_state *ps);

    Can this be added to amdblocks/acpi.h itself?

To view, visit change 56360. To unsubscribe, or for help writing mail filters, visit settings.