Attention is currently required from: Krystian Hebel, Michał Żygowski, Piotr Król, Piotr Kubaj.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81963?usp=email )
Change subject: mb/protectli/vault_cml: use combo v1/v2 FSP
......................................................................
Patch Set 8:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81963/comment/94c9e869_f17c9b55 :
PS8, Line 9: Also switch configs to use combo v1/v2 FSP
I think the only differences between these FSP binaries are in FSP-M, so you could technically use two FSP-M binaries but only a single FSP-S binary. No idea if that's worth the flash chip space savings, though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81963?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1a6f6e873e4ec35b9777dc17c0495151348d1d88
Gerrit-Change-Number: 81963
Gerrit-PatchSet: 8
Gerrit-Owner: Piotr Kubaj
pkubaj@anongoth.pl
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Piotr Kubaj
pkubaj@anongoth.pl
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Attention: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Comment-Date: Sun, 28 Apr 2024 09:53:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment