Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34664 )
Change subject: lib/stage_cache: Refactor Kconfig options ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34664/3/src/Kconfig File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/34664/3/src/Kconfig@264 PS3, Line 264: "Cache stages in CBMEM"
Disabled cache, there are empty stubs in stage_cache.h. The case of your first comment.
Done
https://review.coreboot.org/c/coreboot/+/34664/3/src/Kconfig@1164 PS3, Line 1164: HAVE_ACPI_RESUME
True, but the 'depends on' was there already for (new) TSEG_STAGE_CACHE.
Wouldn't it be better to just have the check in a single place especially if we are keeping the scope open for being able to add other ways of having external stage cache?
https://review.coreboot.org/c/coreboot/+/34664/3/src/include/stage_cache.h File src/include/stage_cache.h:
https://review.coreboot.org/c/coreboot/+/34664/3/src/include/stage_cache.h@3... PS3, Line 35: CONFIG(TSEG_STAGE_CACHE) || CONFIG(CBMEM_STAGE_CACHE)
Exactly, CBMEM_STAGE_CACHE is user settable.
Done
https://review.coreboot.org/c/coreboot/+/34664/3/src/include/stage_cache.h@5... PS3, Line 54: external
Well the API is not restricted to TSEG. Just that at the moment we do not provide other choices. […]
Done