Attention is currently required from: Felix Singer, Martin L Roth.
Elyes Haouas has uploaded a new patch set (#2) to the change originally created by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/76855?usp=email )
The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins)
Change subject: util/docker: Don't install python modules as root ......................................................................
util/docker: Don't install python modules as root
When installing the python modules with pip3 as root, the installer throws a lot of warnings about conflicts and recommends that it not be run that way. This change installs the python modules as the coreboot user instead. The --break-system-packages argument can now be removed.
It takes along some other changes made to the coreboot home directory which also don't need to be run as root, and now adds the .local/bin directory into the path.
The trailing docker PATH configuration is discarded as cleanup - it doesn't have any effect. Nothing uses it in the Dockerfile, and it doesn't end up updating the path, which is set by /etc/profile.
Change-Id: Ie8273009bb527e267584bba84504191aa7294ca3 Signed-off-by: Martin Roth gaumless@gmail.com --- M util/docker/coreboot-jenkins-node/Dockerfile 1 file changed, 17 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/76855/2