Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42141 )
Change subject: ec/google/wilco: Fix comment about enclosure type ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42141/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42141/1//COMMIT_MSG@7 PS1, Line 7: Fix The comment was not wrong per se, as long as selecting SYSTEM_TYPE_CONVERTIBLE resulted in the SMBIOS enclosure type being SMBIOS_ENCLOSURE_CONVERTIBLE. Is that true?
https://review.coreboot.org/c/coreboot/+/42141/1/src/ec/google/wilco/acpi/vb... File src/ec/google/wilco/acpi/vbtn.asl:
https://review.coreboot.org/c/coreboot/+/42141/1/src/ec/google/wilco/acpi/vb... PS1, Line 8: * have SMBIOS_ENCLOSURE_CONVERTIBLE for the SMBIOS enclosure type to IMHO, this makes it too tempting to manually set the SMBIOS enclosure type for this code to work. If we want people to select SYSTEM_TYPE_CONVERTIBLE instead, the original wording would be more appropriate.