Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40670 )
Change subject: arch/x86/acpigen: Add helpers for generating _ADR ......................................................................
Patch Set 1:
(1 comment)
Patch Set 1: Code-Review+2
I just wrote one for soundwire as well, was wondering where to put it so now I will add it here.
Yeah, I realized that you might be needing this for Soundwire as well.
https://review.coreboot.org/c/coreboot/+/40670/1/src/arch/x86/include/arch/a... File src/arch/x86/include/arch/acpigen.h:
https://review.coreboot.org/c/coreboot/+/40670/1/src/arch/x86/include/arch/a... PS1, Line 374: void acpigen_write_ADR_pci(pci_devfn_t devfn);
I think it might be helpful to add two variants of ADR: […]
That makes sense. I will add that.