[coreboot-gerrit] Change in coreboot[master]: nb/via/vx900: Ensure framebuffer size is within limits

[Jacob Garber (Code Review)]

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34355 )

Change subject: nb/via/vx900: Ensure framebuffer size is within limits
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34355/3/src/northbridge/via/vx900/m... 
File src/northbridge/via/vx900/memmap.c:

https://review.coreboot.org/c/coreboot/+/34355/3/src/northbridge/via/vx900/m... 
PS3, Line 83: 	assert(size_mb != 0);
> Just realized: Even if the assert does not fire (not sure how coreboot handles them), the code will  […]

The rest of the code technically rounds down to the nearest power of 2, so I suppose that comment is a bit inaccurate - I'll fix it. In any event I think we should leave this assertion in, because having a zero size framebuffer is very wrong.