HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40689 )
Change subject: {icelake,jasperlake,skylake,tigerlake}/bootblock.c: Drop unused includes ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/icelake/bootb... File src/soc/intel/icelake/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/icelake/bootb... PS4, Line 20:
pch_early_iorange_init() ? […]
Done
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/skylake/bootb... File src/soc/intel/skylake/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/skylake/bootb... PS4, Line 4: #include <intelblocks/systemagent.h>
Ack
Done
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/tigerlake/boo... File src/soc/intel/tigerlake/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/tigerlake/boo... PS4, Line 20:
Er...
I don't understand...
'bootblock_systemagent_early_init()' is here: <soc/bootblock.h> 'bootblock_pch_early_init()' is here: <soc/bootblock.h> 'bootblock_cpu_init()' is here: <soc/bootblock.h> 'pch_early_iorange_init()' is also here: <soc/bootblock.h>