Attention is currently required from: Arthur Heymans, Kyösti Mälkki.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74441 )
Change subject: cpu/intel/speedstep: Use acpigen_write_processor_device() ......................................................................
Patch Set 4:
(1 comment)
File src/southbridge/intel/i82801jx/fadt.c:
https://review.coreboot.org/c/coreboot/+/74441/comment/c6919fff_84199849 PS4, Line 25: fadt->p_lvl3_lat = 0; /* FIXME: Is this correct? */
Commit message hopefully raises enough eyebrows for someone to act on a fix without degraded perform […]
Removing the FIXME probably won't get heads up. At least that's how I understand it, the patch doesn't effectively change the value, right? And that's where I see it potentially disagreeing with the commit message.
But let me ask differently, what's the incentive to drop the FADT fallback values?