Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43166 )
Change subject: mb/siemens/mc_apl1: Use OPCODE menu set up of fast SPI driver ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43166/1/src/mainboard/siemens/mc_ap... File src/mainboard/siemens/mc_apl1/mainboard.c:
https://review.coreboot.org/c/coreboot/+/43166/1/src/mainboard/siemens/mc_ap... PS1, Line 204: fast_spi_set_opcode_menu();
This is not seem mainboard specific? Any reason it happens here? BTW who is locking things down?
Lockdown is handled in FSP. And though it is not mainboard specific there is no need to have it set up unless you want to use the SPI controller to flash you chip from OS using hardware accelerated access. As I cannot take this decision for every usage I enable it just for our mainboards.