Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Ivy Jian.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61663 )
Change subject: mb/google/var/banshee: Add gpios to lock
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brya/variants/banshee/gpio.c:
https://review.coreboot.org/c/coreboot/+/61663/comment/48c35974_b4c6ff6c
PS1, Line 148: PAD_NC(GPP_E17, NONE),
Should this be PAD_NC_LOCK(GPP_E17, NONE, LOCK_CONFIG)?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61663
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5a2136e57e842fbd0b2c2836833106e7344afee
Gerrit-Change-Number: 61663
Gerrit-PatchSet: 3
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Comment-Date: Mon, 07 Feb 2022 08:04:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-MessageType: comment