Matt Delco has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42205 )
Change subject: mb/google/dedede: Add ACPI support for camera in waddledee
......................................................................
Patch Set 9:
Patch Set 9:
Hello Tim, yes, the patch train you have shared has one known limitation it cannot support the ASL generation in a case where we have shared power resources across two camera (sugnan is working on it), till the time new patches are reviewed and merged we will need this patch.
A potential hybrid approach (ideally for the intermediate term) is to keep the PowerResources in ASL files but use the mipi_camera driver for everything else. That's basically what I was doing before the mipi_camera driver was enhanced to handle power, e.g.:
https://review.coreboot.org/c/coreboot/+/31166
https://review.coreboot.org/c/coreboot/+/31164
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42205
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f6b490832d2c34c86512384eb7470f13a212a66
Gerrit-Change-Number: 42205
Gerrit-PatchSet: 9
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt Delco
delco@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Comment-Date: Mon, 06 Jul 2020 16:43:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment