Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38858 )
Change subject: security/tpm: Include mrc.bin in CRTM if present ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/38858/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38858/1//COMMIT_MSG@9 PS1, Line 9: where it presents *where it is present* or *where present*
https://review.coreboot.org/c/coreboot/+/38858/1/src/lib/cbfs.c File src/lib/cbfs.c:
https://review.coreboot.org/c/coreboot/+/38858/1/src/lib/cbfs.c@61 PS1, Line 61: if (fmap_locate_area_as_rdev("COREBOOT", &rdev)) Why do you use the FMAP method?
https://review.coreboot.org/c/coreboot/+/38858/1/src/lib/cbfs.c@65 PS1, Line 65: Please remove the blank line.
https://review.coreboot.org/c/coreboot/+/38858/1/src/lib/cbfs.c@102 PS1, Line 102: int ret I think this should be declared at the top.