Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40769 )
Change subject: soc/amd/sata: Move SATA PCI device from DSDT to SSDT
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40769/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40769/1//COMMIT_MSG@11
PS1, Line 11:
What is the advantage of having it in SSDT?
It allows to keep the ACPI name and the devices in sync. There were some inconsistencies that were noticed which was causing either the device to be added under the wrong path in DSDT or name getting out of sync.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40769
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I16ac36d997496ff33c5b44ec9bd2731b2b8799eb
Gerrit-Change-Number: 40769
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 28 Apr 2020 18:25:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment