Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48158 )
Change subject: soc/intel/apollolake: LZ4 Compress FSP-M ......................................................................
Patch Set 2:
Patch Set 1:
Patch Set 1:
Patch Set 1: Code-Review+1
Hmm, Picasso is using LZMA. Unsure how Furquan decided on that vs. LZ4 in cb:41830.
In resource constrained environments (so pre-RAM environments) LZ4 is somewhat safer as the stack usage is quite limited. If you boot into ram you probably want the highest possible compression ratio without caring about stack usage.
As mentioned in the commit message on CB:41830, I did it primarily based on the size of the compressed binary for Picasso.
Ah thanks, that was very good.