Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46961 )
Change subject: drivers/usb/acpi: Add support for privacy_gpio ......................................................................
Patch Set 3: Code-Review+1
(2 comments)
LGTM. We just need to co-ordinate with CB:46713 to ensure the changes don't conflict.
https://review.coreboot.org/c/coreboot/+/46961/3/src/drivers/usb/acpi/chip.h File src/drivers/usb/acpi/chip.h:
https://review.coreboot.org/c/coreboot/+/46961/3/src/drivers/usb/acpi/chip.h... PS3, Line 51: recodring nit: recording
https://review.coreboot.org/c/coreboot/+/46961/3/src/drivers/usb/acpi/usb_ac... File src/drivers/usb/acpi/usb_acpi.c:
https://review.coreboot.org/c/coreboot/+/46961/3/src/drivers/usb/acpi/usb_ac... PS3, Line 11: usb_acpi_add_gpios_to_crs Looks like there is another change that is touching the same file/function - CB:46713.
We will have to rebase on top of it.