Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32407 )
Change subject: soc/amd/picasso: Create picasso as a copy of stoneyridge ......................................................................
Patch Set 1:
Martin, I feel your pain here. But is this platform AGESA v8 or AGESA v9?
You should revisit old reviews when StoneyPI commits first started to appear. Go back to those early 2017 (?) days where I have to fight against Marc and Marshall about somewhat "simple things" like countless of TODOs and FIXMEs that were left behind and copy-pasted from previous binaryPI, again copied from AGESA. At times, there were (accidental) pushes that just removed some TODO comments withoutexplanations.
One thing came clear during StoneyPI reviews; even for staff at Silverback AGESA v8 and agesawrapper.c in particular was a complete mis(t)ery. Revisit reviews, and notice how many times I personally had to step in on the reviews and tell the code you had copied from binaryPI was not good at all.
https://blogs.coreboot.org/blog/2014/08/03/gsoc-infrastructure-along-the-way...