Martin, I feel your pain here. But is this platform AGESA v8 or AGESA v9?

You should revisit old reviews when StoneyPI commits first started to appear. Go back to those early 2017 (?) days where I have to fight against Marc and Marshall about somewhat "simple things" like countless of TODOs and FIXMEs that were left behind and copy-pasted from previous binaryPI, again copied from AGESA. At times, there were (accidental) pushes that just removed some TODO comments withoutexplanations.

One thing came clear during StoneyPI reviews; even for staff at Silverback AGESA v8 and agesawrapper.c in particular was a complete mis(t)ery. Revisit reviews, and notice how many times I personally had to step in on the reviews and tell the code you had copied from binaryPI was not good at all.

https://blogs.coreboot.org/blog/2014/08/03/gsoc-infrastructure-along-the-way-something-went-terribly-wrong/

View Change

To view, visit change 32407. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6809bd1eea304f76dd9000c079b3ed09f94dbd3b
Gerrit-Change-Number: 32407
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Comment-Date: Fri, 26 Apr 2019 16:02:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment