Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39338 )
Change subject: mb/google/volteer: modify and add some devicetree settings ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39338/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/39338/3/src/mainboard/google/voltee... PS3, Line 53: register "sdcard_cd_gpio" = "GPP_E11" This is not correct. Not required.
https://review.coreboot.org/c/coreboot/+/39338/3/src/mainboard/google/voltee... PS3, Line 117: # iDisp-Link T-Mode 0: 2T, 2: 4T, 3: 8T, 4: 16T : register "PchHdaIDispLinkTmode" = "2" : # iDisp-Link Freq 4: 96MHz, 3: 48MHz. : register "PchHdaIDispLinkFrequency" = "4" : # Not disconnected/enumerable : register "PchHdaIDispCodecDisconnect" = "0" I don't think this is correct for Volteer. We do not use IDisp. Have you verified this is really required?