[coreboot-gerrit] Change in coreboot[master]: mb/teleplatforms/D4E4S16P8: Add new CRB teleplatforms/D4E4S16P8

[Kyösti Mälkki (Code Review)]

Attention is currently required from: Дмитрий Понаморев, Mariusz Szafrański, Paul Menzel, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Patrick Rudolph, King Sumo.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57194 )

Change subject: mb/teleplatforms/D4E4S16P8: Add new CRB teleplatforms/D4E4S16P8
......................................................................

Patch Set 18:

(5 comments)

File configs/config.teleplatforms.D4E4S16P8:

PS18: 
This config will not build until 3rdparty/blobs is merged

File src/mainboard/teleplatforms/D4E4S16P8/Kconfig:

https://review.coreboot.org/c/coreboot/+/57194/comment/8d71e296_b8ca61b3 
PS17, Line 42: config ENABLE_FSP_MEMORY_DOWN
> Board has DIMM slots, I'll separate this feature as debugging aid, and it's unlikely to be merged.

Done

File src/mainboard/teleplatforms/D4E4S16P8/boardid.c:

https://review.coreboot.org/c/coreboot/+/57194/comment/b87fd4cd_5e19032f 
PS17, Line 6: uint8_t board_id(void)
> No real board_id(), I will remove. […]

Done

File src/mainboard/teleplatforms/D4E4S16P8/emmc.h:

https://review.coreboot.org/c/coreboot/+/57194/comment/e3d390ea_415f510a 
PS17, Line 11: BL_EMMC_INFORMATION D4E4S16P8_emmc_config[] = {
> eMMC is not routed and 0:1c. […]

Done

File src/mainboard/teleplatforms/D4E4S16P8/romstage.c:

https://review.coreboot.org/c/coreboot/+/57194/comment/ddda7ffe_3100ecdf 
PS17, Line 102: 	if (!CONFIG(ENABLE_FSP_MEMORY_DOWN))
> You would never set this for a board with DIMM slots, except for occasional debug use if reading SPD […]

Done