Attention is currently required from: Raul Rangel, Paul Menzel, Stefan Reinauer, Julius Werner, Jacob Garber, Iru Cai.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40811 )
Change subject: arch,toolchain,xcompile: Use GCC as linker
......................................................................
Patch Set 11:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/40811/comment/0dd73d95_27bd3a1f
PS11, Line 7: arch,toolchain,xcompile: Use GCC as linker
:
: Code generation when using LTO is not done until after linking, so the
: compiler must be invoked at all linking stages instead of the linker.
: Replace $(LD) with GCC, and prefix all linker-specific flags with -Wl so
: they will be passed to the linker.
GCC is not the only compiler supported by now.
Patchset:
PS11:
It looks like clang tries to use /usb/bin/ld by default. It should use something like -fuse-ld=$(LD_common).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40811
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia551cf84c8f6eb3b010450fc572876a318a257d1
Gerrit-Change-Number: 40811
Gerrit-PatchSet: 11
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Iru Cai
mytbk920423@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Keith Hui
buurin@gmail.com
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Attention: Iru Cai
mytbk920423@gmail.com
Gerrit-Comment-Date: Tue, 10 Jan 2023 11:02:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment