Attention is currently required from: Felix Singer, Kapil Porwal, Nick Vaccaro, Varshit Pandya.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81631?usp=email )
Change subject: mb/google/brya: Sort Kconfig option alphabetically
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/81631/comment/b81b57b8_adaab108 :
PS3, Line 574: config DRIVER_TPM_I2C_BUS
Lines can be continued with backslashes. I feel this way it's much better structured and readable. […]
i don't have a super strong opinion on this, but i'd keep using one line per board here, since that minimizes the possible merge conflicts when additional boards are added. it will probably also make it easier to do that via the script that adds a new variant; never looked into how that works exactly though
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81631?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I878c14058e1edc0f64e37c2fc16b8dcf75b90192
Gerrit-Change-Number: 81631
Gerrit-PatchSet: 3
Gerrit-Owner: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Fri, 05 Apr 2024 12:32:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-MessageType: comment