Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38670 )
Change subject: asus/p2b*: Move serial init into mainboard bootblock
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38670/2/src/northbridge/intel/i440b...
File src/northbridge/intel/i440bx/romstage.c:
https://review.coreboot.org/c/coreboot/+/38670/2/src/northbridge/intel/i440b...
PS2, Line 24: console_init
Where did this call go?
cpu/intel/car/romstage.c
That call will work once serial init is moved to bootblock.
https://review.coreboot.org/c/coreboot/+/38670/2/src/northbridge/intel/i440b...
PS2, Line 17: #include <console/console.h>
This header isn't needed anymore, I guess?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38670
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f3ee68e7c76a8c6db6d75956e6a7fb75ef83850
Gerrit-Change-Number: 38670
Gerrit-PatchSet: 6
Gerrit-Owner: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 12 Apr 2020 23:44:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment