[coreboot-gerrit] Change in coreboot[master]: soc/intel/cnl: Allow enabling/disabling GNA device

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44739 )

Change subject: soc/intel/cnl: Allow enabling/disabling GNA device
......................................................................

Patch Set 13:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44739/13/src/soc/intel/cannonlake/f... 
File src/soc/intel/cannonlake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/44739/13/src/soc/intel/cannonlake/f... 
PS13, Line 529: GnaEnable
> same as chap; do we want to have that in the devtree? I think the gna device is user-specific, iow g […]

I agree. This is nothing a developer can or should have to decide. I some-
times dream about having implicit NVRAM options to override such things
(i.e. the devicetree would only provide a default and NVRAM could override),
but we are not there yet ;)