17 Feb
2020
17 Feb
'20
8:41 a.m.
Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38714 )
Change subject: trogdor: Latch GPIO interrupt support ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38714/3/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/chromeos.c:
https://review.coreboot.org/c/coreboot/+/38714/3/src/mainboard/google/trogdo... PS3, Line 53: GPIO_H1_AP_INT
...and what about gpio_input_irq()? It's not going to initialize itself... […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/38714
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8198213cf2808be5291620892185b1e534263e3f
Gerrit-Change-Number: 38714
Gerrit-PatchSet: 7
Gerrit-Owner: mturney mturney mturney@codeaurora.org
Gerrit-Reviewer: Ravi kumar rbokka@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney mturney@codeaurora.org
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Mon, 17 Feb 2020 16:41:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment