build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37029 )
Change subject: security/tpm: Drop CAR_GLOBAL_MIGRATION support ......................................................................
Patch Set 4:
(11 comments)
https://review.coreboot.org/c/coreboot/+/37029/4/src/drivers/crb/tis.c File src/drivers/crb/tis.c:
https://review.coreboot.org/c/coreboot/+/37029/4/src/drivers/crb/tis.c@23 PS4, Line 23: static unsigned tpm_is_open; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/37029/4/src/drivers/crb/tis.c@71 PS4, Line 71: tpm_is_open = 0; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37029/4/src/drivers/i2c/tpm/cr50.c File src/drivers/i2c/tpm/cr50.c:
https://review.coreboot.org/c/coreboot/+/37029/4/src/drivers/i2c/tpm/cr50.c@... PS4, Line 61: static int warning_displayed ; space prohibited before semicolon
https://review.coreboot.org/c/coreboot/+/37029/4/src/drivers/i2c/tpm/tpm.c File src/drivers/i2c/tpm/tpm.c:
https://review.coreboot.org/c/coreboot/+/37029/4/src/drivers/i2c/tpm/tpm.c@8... PS4, Line 83: static struct tpm_inf_dev g_tpm_dev ; space prohibited before semicolon
https://review.coreboot.org/c/coreboot/+/37029/4/src/drivers/pc80/tpm/tis.c File src/drivers/pc80/tpm/tis.c:
https://review.coreboot.org/c/coreboot/+/37029/4/src/drivers/pc80/tpm/tis.c@... PS4, Line 164: static u32 vendor_dev_id ; space prohibited before semicolon
https://review.coreboot.org/c/coreboot/+/37029/4/src/drivers/spi/tpm/tis.c File src/drivers/spi/tpm/tis.c:
https://review.coreboot.org/c/coreboot/+/37029/4/src/drivers/spi/tpm/tis.c@1... PS4, Line 12: static unsigned tpm_is_open; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/37029/4/src/drivers/spi/tpm/tpm.c File src/drivers/spi/tpm/tpm.c:
https://review.coreboot.org/c/coreboot/+/37029/4/src/drivers/spi/tpm/tpm.c@6... PS4, Line 68: warning_displayed = 1; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37029/4/src/drivers/spi/tpm/tpm.c@2... PS4, Line 212: static unsigned prev_reg; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/37029/4/src/drivers/spi/tpm/tpm.c@2... PS4, Line 228: if (prev_prefix != *prefix) || trailing statements should be on next line
https://review.coreboot.org/c/coreboot/+/37029/4/src/drivers/spi/tpm/tpm.c@4... PS4, Line 411: int tpm2_init(struct &g_spi_slave *spi_if) need consistent spacing around '&' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/37029/4/src/drivers/spi/tpm/tpm.c@4... PS4, Line 411: int tpm2_init(struct &g_spi_slave *spi_if) need consistent spacing around '*' (ctx:WxV)