Tim Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41232 )
Change subject: drivers/ocp/ipmi: Implement set POST start/end command ......................................................................
Patch Set 1:
(2 comments)
Patch Set 1:
Patch Set 1:
Patch Set 1:
Patch Set 1:
What's ipmi init? Do you have a specification that describes this more briefly?
"wait for the finish of ipmi init" is not suitable in my last reply. The reason I add this command in ramstage is that "post start" should wait BMC ready.
About OEM IPMI start command, in CB:40234 it adds ipmi_kcs_premem_init() which waits for BMC ready in romstage, and is called in CB:39690. So I think calling IPMI start command can be done in romstage which is earlier than ramstage. The only thing is that in romstage I need to pass BMC KCS address to the function. Hi Jonathan, Should we put all common IPMI OEM commands in this driver? Such as OEM start, stop, set PPIN .,etc. For different mainboard code we can call this driver/library to avoid duplicating the same codes.
Hi Johnny, I agree that gradually we should put all common IPMI OEM commands (that are used by OCP servers) in this driver. Hi Tim, thanks for putting this patch together. Suggest to split this patch into two: the first one is for drivers/ocp/ipmi, another is for mb/ocp/tiogapass.
Hi Jonathan, I've split this patch into two. One is in CB:41604, another is in CB:41605.
https://review.coreboot.org/c/coreboot/+/41232/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41232/1//COMMIT_MSG@9 PS1, Line 9: Implemented to send POST start and POST end command to BMC in ramstage.
Implemented to send --> Implemented sending. […]
Done
https://review.coreboot.org/c/coreboot/+/41232/1/src/drivers/ocp/ipmi/ipmi_o... File src/drivers/ocp/ipmi/ipmi_ocp.h:
https://review.coreboot.org/c/coreboot/+/41232/1/src/drivers/ocp/ipmi/ipmi_o... PS1, Line 1: /* This file is part of the coreboot project. */
Instead we just need this single line: […]
Done