Attention is currently required from: Raul Rangel, Furquan Shaikh, Martin Roth, Mathew King.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52908 )
Change subject: mb/google/guybrush: Configure wake resource for WiFi
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52908/comment/a5353a2c_1426e04f
PS1, Line 13: is added to SSDT.
Yes, I tried both powerd_dbus_suspend as well as writing directly to sysfs power_state and the issue […]
There were 2 issues:
1) WWAN module is pulling the WAKE_L line always low. This caused the EDGE_LOW to not happen. So I pulled out the WWAN module.
2) User error. After removing the WWAN module, I forgot to turn on wake on wlan events. After turning on Wake on WLAN events, both /proc/acpi/wakeup and GPE_EN are reflecting as expected. The system was able to wake on WLAN events.
If there are no objections, I will mark this as resolved.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52908
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic238d9606aea20c058e9b47093693f10b14e6288
Gerrit-Change-Number: 52908
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Mathew King
mathewk@chromium.org
Gerrit-Comment-Date: Tue, 11 May 2021 21:54:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment