Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46056 )
Change subject: acpi/device: Add GPIO binding property for an array of GPIOs ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46056/1/src/include/acpi/acpi_devic... File src/include/acpi/acpi_device.h:
https://review.coreboot.org/c/coreboot/+/46056/1/src/include/acpi/acpi_devic... PS1, Line 550: index Might be good to call this "start_index" and add a comment that it must match the defined GPIOs in the _CRS without gaps.
https://review.coreboot.org/c/coreboot/+/46056/1/src/include/acpi/acpi_devic... PS1, Line 550: pin We do support adding a gpio into _CRS with multiple pins (https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src...) but I'm not sure how best to handle that here since it is probably not the common case. Perhaps also with a comment that this expects one gpio entry per pin? And in that case perhaps pin should not even be a provided argument to the array method since it only works with pin 0.