16 Jul
2019
16 Jul
'19
6:42 p.m.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34356 )
Change subject: ec/google/chromeec: Pass reference of object to BBST() method ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34356/1/src/ec/google/chromeec/acpi... File src/ec/google/chromeec/acpi/battery.asl:
https://review.coreboot.org/c/coreboot/+/34356/1/src/ec/google/chromeec/acpi... PS1, Line 198: Store (Local1, Arg2) I guess statements like this should only be valid if Arg2 (which is an input) is a RefOf?
--
To view, visit https://review.coreboot.org/c/coreboot/+/34356
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia8e207a2990059a60d96d8e0f3ed3c16a55c50f4
Gerrit-Change-Number: 34356
Gerrit-PatchSet: 1
Gerrit-Owner: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Georgi pgeorgi@google.com
Gerrit-Comment-Date: Tue, 16 Jul 2019 16:42:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment