Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37262?usp=email ) Change subject: util: cbfstool: Check alignment at build time ...................................................................... Patch Set 11: (1 comment) Patchset: PS11: Let's try to follow up again. So, - All FMAP sections are default to be aligned (4k). - The implementation should still default to 4k aligned. Runtime erasing is not covered by this change. We can revisit again when seeing more non-4k chipsets. I think the unclear part is how we handle sections that do not need to be aligned. Proposals from the discussions: 1. Use '/<alignment>' so /0 /1 both are unaligned, indicating 'size % a == 0'. Can support arbitrary numbers like '/512' (but will that make people confused by really dividing the alignment?) 2. Use '%<alignment>' so %0 %1 both are unaligned, indicating 'size % a == 0'. Can support arbitrary numbers like '%512'. 3. Use '%' for unaligned, indicating 'size % 4k != 0' 4. Use flags 'UNALIGNED' to make it explicit. 4 is easiest to read without confusion. 3 is efficient but can be misleading. Maybe go back with 1 or 2? -- To view, visit https://review.coreboot.org/c/coreboot/+/37262?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I26b394590c28667a4afcd521c7caa2009b5b98a9 Gerrit-Change-Number: 37262 Gerrit-PatchSet: 11 Gerrit-Owner: Hung-Te Lin <hungte@chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh@gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte@chromium.org> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Aaron Durbin <adurbin@chromium.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-CC: Wim Vervoorn <wvervoorn@eltan.com> Gerrit-Comment-Date: Wed, 14 Jun 2023 02:25:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment