View Change

1 comment:

• Patchset:

  • Patch Set #11:

    Let's try to follow up again.

    So,

    • All FMAP sections are default to be aligned (4k).
    • The implementation should still default to 4k aligned. Runtime erasing is not covered by this change. We can revisit again when seeing more non-4k chipsets.

    I think the unclear part is how we handle sections that do not need to be aligned.

    Proposals from the discussions:

    1. Use '/<alignment>' so /0 /1 both are unaligned, indicating 'size % a == 0'. Can support arbitrary numbers like '/512' (but will that make people confused by really dividing the alignment?)

    2. Use '%<alignment>' so %0 %1 both are unaligned, indicating 'size % a == 0'. Can support arbitrary numbers like '%512'.

    3. Use '%' for unaligned, indicating 'size % 4k != 0'

    4. Use flags 'UNALIGNED' to make it explicit.

    
    4 is easiest to read without confusion. 3 is efficient but can be misleading. Maybe go back with 1 or 2?

To view, visit change 37262. To unsubscribe, or for help writing mail filters, visit settings.