[coreboot-gerrit] Change in coreboot[master]: drivers/vpd: Add support to read device serial from VPD

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49050 )

Change subject: drivers/vpd: Add support to read device serial from VPD
......................................................................

Patch Set 1:

(3 comments)

https://review.coreboot.org/c/coreboot/+/49050/1/src/drivers/vpd/vpd.c 
File src/drivers/vpd/vpd.c:

https://review.coreboot.org/c/coreboot/+/49050/1/src/drivers/vpd/vpd.c@303 
PS1, Line 303: mlb
is that a typo or is that a name from some spec?

https://review.coreboot.org/c/coreboot/+/49050/1/src/drivers/vpd/vpd.c@308 
PS1, Line 308: static
why static?

https://review.coreboot.org/c/coreboot/+/49050/1/src/drivers/vpd/vpd.c@306 
PS1, Line 306: har *smbios_system_serial_number(void)
             : {
             : 	static char serial[VPD_SERIAL_LEN];
             : 	if (vpd_gets(VPD_KEY_SYSTEM_SERIAL, serial, VPD_SERIAL_LEN, VPD_RO))
             : 		return serial;
             : 	return "";
             : }
             : 
             : const char *smbios_mainboard_serial_number(void)
             : {
             : 	static char serial[VPD_SERIAL_LEN];
             : 	if (vpd_gets(VPD_KEY_MAINBOARD_SERIAL, serial, VPD_SERIAL_LEN, VPD_RO))
             : 		return serial;
             : 	return "";
             : }
             : #endif
shouldn't that go to smbios and make use of vpd functionality from there? (also the Kconfig)