HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31063 )
Change subject: nb/intel/i945: Fix typo on DMIBAR32(0x334)
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31063/1/src/northbridge/intel/i945/early_ini...
File src/northbridge/intel/i945/early_init.c:
https://review.coreboot.org/#/c/31063/1/src/northbridge/intel/i945/early_ini...
PS1, Line 512:
:
:
:
:
:
Or maybe just bit 3 at 0x338 is RO. That's all we know. […]
yes, I've removed all power and switched on without power in between.
still getting the same values:)
0x0308: 0x00060018
0x0314: 0x00060000
0x0324: 0x00030018
0x0328: 0x00030000
0x0334: 0x00040008
0x0338: 0x00040000
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31063
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib894c24bc787c6c211da26dca78bcd330ded6681
Gerrit-Change-Number: 31063
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 26 Jan 2019 17:09:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment
