Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39034 )
Change subject: soc/mediatek/mt8183: Set correct threshold of EMI bandwidth for DVFS
......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39034/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39034/1//COMMIT_MSG@9
PS1, Line 9: have difference setting
different setting
or
should differ
https://review.coreboot.org/c/coreboot/+/39034/1//COMMIT_MSG@12
PS1, Line 12:
What problem is caused? Failed boot?
What is the difference between d (1101) and a (1010), that means, do the three changed bits do?
https://review.coreboot.org/c/coreboot/+/39034/1//COMMIT_MSG@15
PS1, Line 15: TEST=bootup pass
Before it failed?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39034
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I82c3c70bcd90df3fdd613c0353aba0f176bc82bc
Gerrit-Change-Number: 39034
Gerrit-PatchSet: 1
Gerrit-Owner: huayang duan
huayangduan@gmail.com
Gerrit-Reviewer: Derek Waldner
derek.waldner.os@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: huayang duan
huayangduan@gmail.com
Gerrit-CC: Duan huayang
huayang.duan@mediatek.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 21 Feb 2020 13:54:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment