25 Jan
2019
25 Jan
'19
4:22 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30774 )
Change subject: mb/google/hatch: Configure miscellaneous features ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/#/c/30774/8/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/30774/8/src/mainboard/google/hatch/variants/... PS8, Line 53: # Enable heci communication : register "HeciEnabled" = "1"
This is not correct.
Ack, refer to CB:31097
--
To view, visit https://review.coreboot.org/c/coreboot/+/30774
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iea90a65a77ef5e45a802cfe6fd31e1921163b02b
Gerrit-Change-Number: 30774
Gerrit-PatchSet: 8
Gerrit-Owner: Ronak Kanabar ronak.kanabar@intel.com
Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com
Gerrit-Reviewer: Balaji Manigandan balaji.manigandan@intel.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Furquan Shaikh furquan@google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 25 Jan 2019 19:22:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment