Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32509 )
Change subject: drivers/intel/fsp1_1/cache_as_ram.inc: Reduce max line length to 80.
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/32509/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32509/1//COMMIT_MSG@7
PS1, Line 7: drivers/intel/fsp1_1/cache_as_ram.inc: Reduce max line length to 80.
Please remove the dot at the end.
https://review.coreboot.org/#/c/32509/1/src/drivers/intel/fsp1_1/cache_as_ra...
File src/drivers/intel/fsp1_1/cache_as_ram.inc:
https://review.coreboot.org/#/c/32509/1/src/drivers/intel/fsp1_1/cache_as_ra...
PS1, Line 216: .long CONFIG_ROM_SIZE /* Firmware Length */ * Length */
Use
/* Firmware Length
Length */
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32509
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib537592c0a6a3fffc85622e6b74ad5ec8041e7dc
Gerrit-Change-Number: 32509
Gerrit-PatchSet: 1
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 29 Apr 2019 11:13:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment