Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32604 )
Change subject: mb/apple: Add MacBook Air 5,2 (A1466)
......................................................................
Patch Set 2:
(1 comment)
This change is ready for review.
https://review.coreboot.org/#/c/32604/1/src/mainboard/apple/macbookair5_2/Kc...
File src/mainboard/apple/macbookair5_2/Kconfig:
https://review.coreboot.org/#/c/32604/1/src/mainboard/apple/macbookair5_2/Kc...
PS1, Line 45: 60
Schematics say GPIO28 (see ISOLATE_CPU_MEM_L). […]
Yes. In 4,2 schematics it's also GPIO28.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32604
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1ebe6f87a8254871698be74f913b9d969d722447
Gerrit-Change-Number: 32604
Gerrit-PatchSet: 2
Gerrit-Owner: Evgeny Zinoviev
me@ch1p.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 05 May 2019 11:24:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment