Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42064 )
Change subject: soc/amd/picasso: Split I2c implementation for psp_verstage ......................................................................
Patch Set 2: Code-Review-1
(2 comments)
https://review.coreboot.org/c/coreboot/+/42064/2/src/soc/amd/picasso/i2c.c File src/soc/amd/picasso/i2c.c:
https://review.coreboot.org/c/coreboot/+/42064/2/src/soc/amd/picasso/i2c.c@a... PS2, Line 7: #include <device/device.h> don't remove. config_of_soc() is used in new code added
https://review.coreboot.org/c/coreboot/+/42064/2/src/soc/amd/picasso/i2c.c@9 PS2, Line 9: #include <soc/soc_util.h> remove. isn't used and can only be used in ramstage (ok, after fsp-m wrote the hobs to be precise) anyway