Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36867 )
Change subject: cbfs: Make cbfs_default_props() hidden again ......................................................................
Patch Set 1:
Patch Set 1:
Why not leave it like this for the next time someone may need it? (Technically, for the apollolake implementation it would also be a bit cleaner to call into this rather than reimplement it.)
I was just trying to clean up the surface area. I'll make apollolake use it.
Another question for you: I looked at this for a few mins earlier. We're currently utilizing offset/size properties. Should we make this API fill out a region device?
int (*locate)(const struct region_device *boot_ro, struct region_device *cbfs_rdev);
the only other place we use offset/size directly is in the coreboot table formation, but I was wondering if there's any added benefit to the change. One side effect would be that rdev_chain() has to be done within each of the callbacks instead of cbfs_boot_locate().