Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47154 )
Change subject: mb/google/dedede/variants: Update Power Limit2 minimum value ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47154/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47154/2//COMMIT_MSG@10 PS2, Line 10: madoo
What about drawcia and magalor?
I have done changes for drawcia in this CL. For magolor, it has PL2 max as 12W and PL2 min as 7W. Not sure, why PL2 max is 12W here for magolor variant. So, firstly would like to discuss with original submitter of the CL on why PL2 max is 12W to understand it better. Later, will submit CL for magolor to make both PL2 max and min the same value. OR do you suggest to change the PL2 min to 12W here for magolor the same as PL2 max ?
https://review.coreboot.org/c/coreboot/+/47154/2//COMMIT_MSG@10 PS2, Line 10: baseboard
Rather than saying baseboard, it would be better to list all variants that are impacted i.e. […]
Under dedede, I checked all the variants. Only baseboard and drawcia needs this change. Other variants like boten, waddledee, waddledoo, metaknight, wheelie are not having these DTT entries.