HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33781 )
Change subject: nb/i945: Consolidate sdram_setup_processor_side()
......................................................................
Patch Set 1:
Patch Set 1:
This is no pure consolidation, it's reordering. Can you confirm
by any means that the order doesn't matter?
Well, I can't test it as the silicon_revision of the chip I have is !=0, however, vendor did that ...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33781
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9c5aae06ae8e3643253fe4a5b080448403f81ebc
Gerrit-Change-Number: 33781
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 25 Jun 2019 13:02:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment