Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38512 )
Change subject: soc/intel/skylake: Make TPM reserve area from 20KB to 32KB
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38512/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38512/2//COMMIT_MSG@12
PS2, Line 12: For CR50 TPM device the MMIO size requirement is 32KB (0x8000).
Is this the same Cr50 I'm familiar with? i.e. h1? It's not connected on a bus that can memory map anything nor can the hardware support it without an assist from a host controller somewhere else. I'm perplexed by the motivation of this patch.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38512
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id02a2659ce42f705180370000df89d4f6b64afce
Gerrit-Change-Number: 38512
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 23 Jan 2020 14:31:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment