[coreboot-gerrit] Change in coreboot[master]: arch/x86: Implement RESET_VECTOR_IN_RAM

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35035 )

Change subject: arch/x86: Implement RESET_VECTOR_IN_RAM
......................................................................

Patch Set 17:

(3 comments)

https://review.coreboot.org/c/coreboot/+/35035/17//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/35035/17//COMMIT_MSG@27 
PS17, Line 27: they can be linked with their .data and .bss as normal
fwiw this is not specific to running a stage from dram, but can be done on all stages not running XIP. See (WIP) 36612.

https://review.coreboot.org/c/coreboot/+/35035/17/src/arch/x86/early_ram.ld 
File src/arch/x86/early_ram.ld:

https://review.coreboot.org/c/coreboot/+/35035/17/src/arch/x86/early_ram.ld@... 
PS17, Line 23: _PAD_FOR_ALIGNS
This is a bit weird? Can't you use an ALIGN macro to align things?

https://review.coreboot.org/c/coreboot/+/35035/17/src/arch/x86/early_ram.ld@... 
PS17, Line 25: EARLYRAM_STACK(., _STACK_SIZE)
             : 	PRERAM_CBMEM_CONSOLE(., _CONSOLE_SIZE)
             : 	TIMESTAMP(., _TIMESTAMPS_SIZE)
             : 	#if !CONFIG(NO_FMAP_CACHE)
             : 		FMAP_CACHE(., FMAP_SIZE)
             : 	#endif
Don't you want VBOOT2_WORK somewhere in there?