Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47598 )
Change subject: arch/x86: Remove ID_SECTION_OFFSET ......................................................................
Patch Set 2:
Patch Set 2: Code-Review+2
Patch Set 2:
See related CB:40376 CB:40377 and CB:47602.
A decision should be made if .id section can be dropped and compatibility with old flashrom (and FILO) builds sacrified with some schedule, 2022 at earliest perhaps. I think post-processing approach would allow removal of id.S independently of that.
Any reason not to schedule that earlier? I would think that people update their OS/tools more often than their firmware? How old flashrom are we talking?
From what I remember current flashrom uses .id section to match image against SMBIOS or DMI when invoked with -p internal.
The proposal sounds good. What do you mean with post-processing approach?
CB:47602, instead of filling in proper .id in linking state, reserve the needed 16byte .id reserve as empty and have cbfstool.