Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48145 )
Change subject: mb/kontron/mal10: Use explicit includes ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48145/4/src/mainboard/kontron/mal10... File src/mainboard/kontron/mal10/carriers/t10-tni/gpio.c:
https://review.coreboot.org/c/coreboot/+/48145/4/src/mainboard/kontron/mal10... PS4, Line 4: #include <gpio.h>
I'm confused. […]
well, it's not explicit 😄 suggestion: use the explicit include "soc/gpio.h" here ;)
https://review.coreboot.org/c/coreboot/+/48145/4/src/mainboard/kontron/mal10... File src/mainboard/kontron/mal10/variants/mal10/gpio.c:
https://review.coreboot.org/c/coreboot/+/48145/4/src/mainboard/kontron/mal10... PS4, Line 3: gpio.h soc/gpio.h would be explicit ;)