Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32381 )
Change subject: soc/intel/braswell: add default option to use public FSP
......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/#/c/32381/10/src/drivers/intel/fsp1_1/Kconfig
File src/drivers/intel/fsp1_1/Kconfig:
https://review.coreboot.org/#/c/32381/10/src/drivers/intel/fsp1_1/Kconfig@57
PS10, Line 57: This must match the
: value that is set in the FSP binary
This base if for the non-SecureBoot only! […]
this has been moved to CB:32535
I'm not sure what you're referring to exactly, but if you're using a value other than the default for the 1.1.8.0 FSP binary, then you'd simply continue to override at either the board level or in your .config
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32381
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I43cf18b98c844175a87b61fdbe4b0b24484e5702
Gerrit-Change-Number: 32381
Gerrit-PatchSet: 12
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 02 May 2019 16:46:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frans Hendriks
fhendriks@eltan.com
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment