Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/52513 )
Change subject: soc/intel/cannonlake: Set DIMM_SPD_SIZE to 512 ......................................................................
soc/intel/cannonlake: Set DIMM_SPD_SIZE to 512
All related mainboards are setting DIMM_SPD_SIZE to 512. Therefore, default to 512 in the SoC Kconfig and drop it from related mainboard Kconfigs.
Change-Id: Idb6a0e42961eeb490afd76b4aa7d940961991733 Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/52513 Reviewed-by: Michael Niewöhner foss@mniewoehner.de Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/clevo/cml-u/Kconfig M src/mainboard/google/drallion/Kconfig M src/mainboard/google/hatch/Kconfig M src/mainboard/google/sarien/Kconfig M src/mainboard/prodrive/hermes/Kconfig M src/mainboard/siemens/chili/Kconfig M src/mainboard/system76/gaze15/Kconfig M src/mainboard/system76/lemp9/Kconfig M src/mainboard/system76/oryp5/Kconfig M src/mainboard/system76/whl-u/Kconfig M src/soc/intel/cannonlake/Kconfig 11 files changed, 3 insertions(+), 40 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/clevo/cml-u/Kconfig b/src/mainboard/clevo/cml-u/Kconfig index 17142f3..6d388e7 100644 --- a/src/mainboard/clevo/cml-u/Kconfig +++ b/src/mainboard/clevo/cml-u/Kconfig @@ -61,10 +61,6 @@ int default 2 if BOARD_CLEVO_L140CU_BASE
-config DIMM_SPD_SIZE - int - default 512 - config VGA_BIOS_ID string default "8086,9b41" diff --git a/src/mainboard/google/drallion/Kconfig b/src/mainboard/google/drallion/Kconfig index fdcbd05..31cac26 100644 --- a/src/mainboard/google/drallion/Kconfig +++ b/src/mainboard/google/drallion/Kconfig @@ -45,10 +45,6 @@ int default 2
-config DIMM_SPD_SIZE - int - default 512 - config DRIVER_TPM_I2C_BUS hex default 0x4 diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index 13e4248..c4ca4f9 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -70,10 +70,6 @@ int default 2
-config DIMM_SPD_SIZE - int - default 512 - config ROMSTAGE_SPD_CBFS bool default y if !ROMSTAGE_SPD_SMBUS diff --git a/src/mainboard/google/sarien/Kconfig b/src/mainboard/google/sarien/Kconfig index feed5e9..144e244 100644 --- a/src/mainboard/google/sarien/Kconfig +++ b/src/mainboard/google/sarien/Kconfig @@ -40,10 +40,6 @@ int default 2
-config DIMM_SPD_SIZE - int - default 512 - config DRIVER_TPM_I2C_BUS hex default 0x4 diff --git a/src/mainboard/prodrive/hermes/Kconfig b/src/mainboard/prodrive/hermes/Kconfig index 0219e05..178acce 100644 --- a/src/mainboard/prodrive/hermes/Kconfig +++ b/src/mainboard/prodrive/hermes/Kconfig @@ -50,10 +50,6 @@ string default "variants/$(CONFIG_VARIANT_DIR)/overridetree.cb"
-config DIMM_SPD_SIZE - int - default 512 - config CONSOLE_POST bool default y diff --git a/src/mainboard/siemens/chili/Kconfig b/src/mainboard/siemens/chili/Kconfig index a261abc..4569762 100644 --- a/src/mainboard/siemens/chili/Kconfig +++ b/src/mainboard/siemens/chili/Kconfig @@ -59,10 +59,6 @@ string default "src/mainboard/$(MAINBOARDDIR)/variants/$(CONFIG_VARIANT_DIR)/data.vbt"
-config DIMM_SPD_SIZE - int - default 512 - config CBFS_SIZE hex default 0xb00000 diff --git a/src/mainboard/system76/gaze15/Kconfig b/src/mainboard/system76/gaze15/Kconfig index 12f94c2..aefacdd 100644 --- a/src/mainboard/system76/gaze15/Kconfig +++ b/src/mainboard/system76/gaze15/Kconfig @@ -60,10 +60,6 @@ int default 2
-config DIMM_SPD_SIZE - int - default 512 - config VGA_BIOS_ID string default "8086,9bc4" diff --git a/src/mainboard/system76/lemp9/Kconfig b/src/mainboard/system76/lemp9/Kconfig index bf2af91..675b738 100644 --- a/src/mainboard/system76/lemp9/Kconfig +++ b/src/mainboard/system76/lemp9/Kconfig @@ -57,10 +57,6 @@ int default 2
-config DIMM_SPD_SIZE - int - default 512 - config VGA_BIOS_FILE string default "pci8086,9b41.rom" diff --git a/src/mainboard/system76/oryp5/Kconfig b/src/mainboard/system76/oryp5/Kconfig index 009633d..7ff1424 100644 --- a/src/mainboard/system76/oryp5/Kconfig +++ b/src/mainboard/system76/oryp5/Kconfig @@ -61,10 +61,6 @@ int default 2
-config DIMM_SPD_SIZE - int - default 512 - config POST_DEVICE bool default n diff --git a/src/mainboard/system76/whl-u/Kconfig b/src/mainboard/system76/whl-u/Kconfig index 2861ce55..e93b421 100644 --- a/src/mainboard/system76/whl-u/Kconfig +++ b/src/mainboard/system76/whl-u/Kconfig @@ -73,10 +73,6 @@ int default 2
-config DIMM_SPD_SIZE - int - default 512 - config POST_DEVICE bool default n diff --git a/src/soc/intel/cannonlake/Kconfig b/src/soc/intel/cannonlake/Kconfig index d4bedc1..65277f2 100644 --- a/src/soc/intel/cannonlake/Kconfig +++ b/src/soc/intel/cannonlake/Kconfig @@ -119,6 +119,9 @@ int default 12
+config DIMM_SPD_SIZE + default 512 + config DCACHE_RAM_BASE default 0xfef00000