Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44370 )
Change subject: {sb/intel/*/azalia.c,device/azalia_device.c}: Reduce differences ......................................................................
Patch Set 6: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/44370/6/src/device/azalia_device.c File src/device/azalia_device.c:
https://review.coreboot.org/c/coreboot/+/44370/6/src/device/azalia_device.c@... PS6, Line 137: 50 That doesn't match the code. How about deleting all comments that say "use a X duration/timeout" instead?
https://review.coreboot.org/c/coreboot/+/44370/6/src/device/azalia_device.c@... PS6, Line 141: reg32 = read32(base + HDA_ICII_REG); : reg32 |= HDA_ICII_BUSY | HDA_ICII_VALID; : write32(base + HDA_ICII_REG, reg32); Have you tested this?
https://review.coreboot.org/c/coreboot/+/44370/6/src/device/azalia_device.c@... PS6, Line 226: // NOTE this will break as soon as the azalia_audio get's a bar above 4G.
'get's' may be misspelled - perhaps 'gets'?
Yes, and would be good to fix while we're at it